Hello Bruce, Ferruh, On Tue, Oct 8, 2024 at 3:33 AM Ferruh Yigit <ferruh.yi...@amd.com> wrote: > > On 10/4/2024 5:56 AM, Ferruh Yigit wrote: > > On 8/22/2024 11:41 AM, Bruce Richardson wrote: > >> Testpmd supports the "--cmdline-file" parameter to read a set of initial > >> commands from a file. However, the only indication that this has been > >> done successfully on startup is a single-line message, no output from > >> the commands is seen. > >> > >> To improve usability here, we can use cmdline_new rather than > >> cmdline_file_new and have the output from the various commands sent to > >> stdout, allowing the user to see better what is happening. > >> > >> Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > >> > >> --- > >> v2: use STDOUT_FILENO in place of hard-coded "1" > >> --- > >> > > > > After discussion, I think it is OK to have the update in the testpmd > > (instead of a new function in cmdline), hence; > > > > Acked-by: Ferruh Yigit <ferruh.yi...@amd.com> > Applied to dpdk-next-net/main, thanks.
This patch triggers an error in UNH for Windows builds. Can you have a look? https://lab.dpdk.org/results/dashboard/testruns/logs/1386705/ [756/833] Compiling C object app/dpdk-testpmd.exe.p/test-pmd_cmdline.c.obj FAILED: app/dpdk-testpmd.exe.p/test-pmd_cmdline.c.obj "clang" "-Iapp\dpdk-testpmd.exe.p" "-Iapp" "-I..\app" "-Iapp\test-pmd" "-I..\app\test-pmd" "-Ilib\ethdev" "-I..\lib\ethdev" "-I." "-I.." "-Iconfig" "-I..\config" "-Ilib\eal\include" "-I..\lib\eal\include" "-Ilib\eal\windows\include" "-I..\lib\eal\windows\include" "-Ilib\eal\x86\include" "-I..\lib\eal\x86\include" "-Ilib\eal\common" "-I..\lib\eal\common" "-Ilib\eal" "-I..\lib\eal" "-Ilib\log" "-I..\lib\log" "-Ilib\kvargs" "-I..\lib\kvargs" "-Ilib\net" "-I..\lib\net" "-Ilib\mbuf" "-I..\lib\mbuf" "-Ilib\mempool" "-I..\lib\mempool" "-Ilib\ring" "-I..\lib\ring" "-Ilib\metrics" "-I..\lib\metrics" "-Ilib\telemetry" "-I..\lib\telemetry" "-Ilib\meter" "-I..\lib\meter" "-Ilib\cmdline" "-I..\lib\cmdline" "-Ilib\bitratestats" "-I..\lib\bitratestats" "-Ilib\gro" "-I..\lib\gro" "-Ilib\gso" "-I..\lib\gso" "-Ilib\latencystats" "-I..\lib\latencystats" "-Idrivers\net\i40e" "-I..\drivers\net\i40e" "-Idrivers\net\i40e\base" "-I..\drivers\net\i40e\base" "-Idrivers\bus\pci" "-I..\drivers\bus\pci" "-I..\drivers\bus\pci\windows" "-Ilib\pci" "-I..\lib\pci" "-Idrivers\bus\vdev" "-I..\drivers\bus\vdev" "-Ilib\hash" "-I..\lib\hash" "-Ilib\rcu" "-I..\lib\rcu" "-Idrivers\net\ixgbe" "-I..\drivers\net\ixgbe" "-Idrivers\net\ixgbe\base" "-I..\drivers\net\ixgbe\base" "-Ilib\security" "-I..\lib\security" "-Ilib\cryptodev" "-I..\lib\cryptodev" "-Idrivers\net\iavf" "-I..\drivers\net\iavf" "-Idrivers\common\iavf" "-I..\drivers\common\iavf" "-Idrivers\net\ice" "-I..\drivers\net\ice" "-Idrivers\net\ice\base" "-I..\drivers\net\ice\base" "-Idrivers\net\mlx5" "-I..\drivers\net\mlx5" "-Idrivers\net/mlx5\windows" "-I..\drivers\net\mlx5\windows" "-Idrivers\common\mlx5" "-I..\drivers\common\mlx5" "-Idrivers\common/mlx5\windows" "-I..\drivers\common\mlx5\windows" "-Idrivers\bus\auxiliary" "-I..\drivers\bus\auxiliary" "-IC:\Program Files\Mellanox\MLNX_WinOF2_DevX_SDK\inc" "-Xclang" "-fcolor-diagnostics" "-pipe" "-D_FILE_OFFSET_BITS=64" "-Wall" "-Winvalid-pch" "-Wextra" "-Werror" "-std=c11" "-O3" "-include" "rte_config.h" "-Wcast-qual" "-Wdeprecated" "-Wformat" "-Wformat-nonliteral" "-Wformat-security" "-Wmissing-declarations" "-Wmissing-prototypes" "-Wnested-externs" "-Wold-style-definition" "-Wpointer-arith" "-Wsign-compare" "-Wstrict-prototypes" "-Wundef" "-Wwrite-strings" "-Wno-address-of-packed-member" "-Wno-missing-field-initializers" "-D_GNU_SOURCE" "-D_WIN32_WINNT=0x0A00" "-D_CRT_SECURE_NO_WARNINGS" "-march=native" "-mrtm" "-DALLOW_EXPERIMENTAL_API" "-Wno-deprecated-declarations" -MD -MQ app/dpdk-testpmd.exe.p/test-pmd_cmdline.c.obj -MF "app\dpdk-testpmd.exe.p\test-pmd_cmdline.c.obj.d" -o app/dpdk-testpmd.exe.p/test-pmd_cmdline.c.obj "-c" ../app/test-pmd/cmdline.c ../app/test-pmd/cmdline.c:13692:46: error: use of undeclared identifier 'STDOUT_FILENO' cl = cmdline_new(main_ctx, "testpmd> ", fd, STDOUT_FILENO); ^ 1 error generated. -- David Marchand
