On 10/4/2024 8:18 PM, Dariusz Sosnowski wrote: >> -----Original Message----- >> From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> >> Sent: Friday, October 4, 2024 09:27 >> To: Ferruh Yigit <ferruh.yi...@amd.com>; NBU-Contact-Thomas Monjalon >> (EXTERNAL) <tho...@monjalon.net>; Ori Kam <or...@nvidia.com>; Aman Singh >> <aman.deep.si...@intel.com>; Konstantin Ananyev >> <konstantin.v.anan...@yandex.ru>; Reshma Pattan <reshma.pat...@intel.com>; >> Stephen Hemminger <step...@networkplumber.org>; Akhil Goyal >> <gak...@marvell.com>; Anoob Joseph <ano...@marvell.com>; Potnuri Bharat >> Teja <bha...@chelsio.com>; Hemant Agrawal <hemant.agra...@nxp.com>; >> Sachin Saxena <sachin.sax...@nxp.com>; Matan Azrad <ma...@nvidia.com>; >> Slava Ovsiienko <viachesl...@nvidia.com>; Dariusz Sosnowski >> <dsosnow...@nvidia.com>; Bing Zhao <bi...@nvidia.com>; Suanming Mou >> <suanmi...@nvidia.com>; Chaoyong He <chaoyong...@corigine.com> >> Cc: dev@dpdk.org; Morten Brørup <m...@smartsharesystems.com>; Bruce >> Richardson <bruce.richard...@intel.com> >> Subject: Re: [PATCH] ethdev: convert string initialization >> >> External email: Use caution opening links or attachments >> >> >> On 10/4/24 07:13, Ferruh Yigit wrote: >>> gcc 15 experimental [1], with -Wextra flag, gives warning in variable >>> initialization as string [2]. >>> >>> The warning has a point when initialized variable is intended to use >>> as string, since assignment is missing the required null terminator >>> for this case. But warning is useless for our usecase. >>> >>> In this patch only updated a few instance to show the issue, there are >>> many instances to fix, if we prefer to go this way. >>> Other option is to disable warning but it can be useful for actual >>> string usecases, so I prefer to keep it. >>> >>> Converted string initialization to array initialization. >>> >>> [1] >>> gcc (GCC) 15.0.0 20241003 (experimental) >>> >>> [2] >>> ../lib/ethdev/rte_flow.h:906:36: >>> error: initializer-string for array of ‘unsigned char’ is too long >>> [-Werror=unterminated-string-initialization] >>> 906 | .hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff", >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> ../lib/ethdev/rte_flow.h:907:36: >>> error: initializer-string for array of ‘unsigned char’ is too long >>> [-Werror=unterminated-string-initialization] >>> 907 | .hdr.src_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff", >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> ../lib/ethdev/rte_flow.h:1009:25: >>> error: initializer-string for array of ‘unsigned char’ is too long >>> [-Werror=unterminated-string-initialization] >>> 1009 | "\xff\xff\xff\xff\xff\xff\xff\xff" >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> ../lib/ethdev/rte_flow.h:1012:25: >>> error: initializer-string for array of ‘unsigned char’ is too long >>> [-Werror=unterminated-string-initialization] >>> 1012 | "\xff\xff\xff\xff\xff\xff\xff\xff" >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> ../lib/ethdev/rte_flow.h:1135:20: >>> error: initializer-string for array of ‘unsigned char’ is too long >>> [-Werror=unterminated-string-initialization] >>> 1135 | .hdr.vni = "\xff\xff\xff", >>> | ^~~~~~~~~~~~~~ >>> >>> Signed-off-by: Ferruh Yigit <ferruh.yi...@amd.com> >>> Acked-by: Morten Brørup <m...@smartsharesystems.com> >>> Acked-by: Bruce Richardson <bruce.richard...@intel.com> >> >> >> Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > > Acked-by: Dariusz Sosnowski <dsosnow...@nvidia.com> >
Applied to dpdk-next-net/main, thanks.
