Hi David,
> > Changes in v2:
> > - removed library patch from series
> > - removed PMD logs from external PMD header.
> > - updated doc/api/doxy-api-index.md
> > - Added release notes
> 
> I see changes in wrong patches and the pmd API ending up in
> cnxk_rvu_lf.h instead of rte_pmd_cnxk_rvu_lf.h (which I think was the
> intention).
> 
Thanks for pointing this out.
The logs were moved from external header to internal one.
This got screwed up while rebasing. Will fix in v3

> I am a bit skeptical about the pmd API that gives back a PCI bar
> address to an application.
> It looks more like the pmd specific API is unfinished and you are
> leaving a door open for some guy who has the hw datasheet...
> 
The intention of the driver is to allow mailbox communication between a PF and 
VF/AF application.
The contents of the mailboxes are not defined in the driver and
hence the intent of the raw driver is to be raw which allows application to 
define their mailboxes and
may need to fill the BAR addresses as well for certain actions based on mailbox 
types.
With this driver, the application is given full control of the device.
The driver APIs are generic which can be used by any of the cnxk device.
This can be used as a debugging tool also for any new cnxk device for which the 
formal driver is not ready.

Reply via email to