On Thu, Sep 19, 2024 at 10:02 AM Bruce Richardson <bruce.richard...@intel.com> wrote: > > I was then surprised to read the result: > > ... > > 2024-09-19T07:22:12.6485260Z Checking for size of "void *" : 8 > > 2024-09-19T07:22:12.6485592Z Checking for size of "void *" : 8 > > ... > > > > > > *scratch* *scratch* > > So I retested the series locally on my f39 (the series seemed ok so > > far) but I downgraded meson to 0.53.2 (which is the version forced in > > GHA) and now I observe the same issue. > > > > I suspect something changed in the cross file handling in more recent > > meson versions. > > Likely, the c_args= or [build-in options] part is not read. > > > > Am I doing something wrong? > > > From the docs on cross-files [1], it appears that significant changes to > the cross-file handling was done in 0.56 release. That may be the cause. > I'll have to try some testing myself. > > Overall, I think we haven't increased our minimum meson version in some > time. Maybe it's time to consider doing so in this release or the next one? > Need to look through release notes to see how far forward to jump to see > what extra features might be useful for us to leverage.
Just a note that I think it is safer to wait for the upgrade to meson 0.57 before merging this series. If this upgrade does not happen in this release, I'll merge at least the first patches but keep the old way of testing 32 bits in the devtools script. Ok for you? -- David Marchand
