> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com>
> Sent: Monday, October 7, 2024 9:20 AM
> To: Gowrishankar Muthukrishnan <gmuthukri...@marvell.com>;
> dev@dpdk.org; Akhil Goyal <gak...@marvell.com>; Fan Zhang
> <fanzhang....@gmail.com>
> Cc: Anoob Joseph <ano...@marvell.com>; Richardson, Bruce
> <bruce.richard...@intel.com>; jer...@marvell.com; Ji, Kai <kai...@intel.com>;
> jack.bond-pres...@foss.arm.com; Marchand, David
> <david.march...@redhat.com>; hemant.agra...@nxp.com; De Lara Guarch,
> Pablo <pablo.de.lara.gua...@intel.com>; Trahe, Fiona
> <fiona.tr...@intel.com>; Doherty, Declan <declan.dohe...@intel.com>;
> ma...@nvidia.com; ruifeng.w...@arm.com; Gujjar, Abhinandan S
> <abhinandan.guj...@intel.com>; maxime.coque...@redhat.com;
> chen...@nvidia.com; sunilprakashrao.uttar...@amd.com;
> andrew.bo...@amd.com; ajit.khapa...@broadcom.com;
> raveendra.padasal...@broadcom.com; vikas.gu...@broadcom.com;
> zhangfei....@linaro.org; g.si...@nxp.com; jianjay.z...@huawei.com; Daly,
> Lee <lee.d...@intel.com>; Dooley, Brian <brian.doo...@intel.com>
> Subject: RE: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax
>
> Acked with a small comment.
>
> > -----Original Message-----
> > From: Gowrishankar Muthukrishnan <gmuthukri...@marvell.com>
> > Sent: Friday, October 4, 2024 8:11 AM
> > To: dev@dpdk.org; Akhil Goyal <gak...@marvell.com>; Fan Zhang
> > <fanzhang....@gmail.com>
> > Cc: Anoob Joseph <ano...@marvell.com>; Richardson, Bruce
> > <bruce.richard...@intel.com>; jer...@marvell.com; Kusztal, ArkadiuszX
> > <arkadiuszx.kusz...@intel.com>; Ji, Kai <kai...@intel.com>; jack.bond-
> > pres...@foss.arm.com; Marchand, David <david.march...@redhat.com>;
> > hemant.agra...@nxp.com; De Lara Guarch, Pablo
> > <pablo.de.lara.gua...@intel.com>; Trahe, Fiona
> > <fiona.tr...@intel.com>; Doherty, Declan <declan.dohe...@intel.com>;
> > ma...@nvidia.com; ruifeng.w...@arm.com; Gujjar, Abhinandan S
> > <abhinandan.guj...@intel.com>; maxime.coque...@redhat.com;
> > chen...@nvidia.com; sunilprakashrao.uttar...@amd.com;
> > andrew.bo...@amd.com; ajit.khapa...@broadcom.com;
> > raveendra.padasal...@broadcom.com;
> > vikas.gu...@broadcom.com; zhangfei....@linaro.org; g.si...@nxp.com;
> > jianjay.z...@huawei.com; Daly, Lee <lee.d...@intel.com>; Dooley, Brian
> > <brian.doo...@intel.com>; Gowrishankar Muthukrishnan
> > <gmuthukri...@marvell.com>
> > Subject: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax
Additionally, it should not be a fix.
The RFC mandates usage of the ASN.1, but only in case sharing private key
across the network.
How the Cryptodev should interpret it, is up to the implementation.
> >
> > As per ASN.1 syntax (RFC 3447 Appendix A.1.2), RSA private key would
> > need
> It could be RFC 8017 instead.
> > specification of quintuple along with private exponent.
> > It is up to the implementation to internally handle, but not at RTE
> > itself to make them exclusive each other. Removing union on them
> > allows asymmetric implementation in VirtIO to benefit from the xform as per
> ASN.1 syntax.
> >
> > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukri...@marvell.com>
> > ---
> > lib/cryptodev/rte_crypto_asym.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/cryptodev/rte_crypto_asym.h
> > b/lib/cryptodev/rte_crypto_asym.h index 39d3da3952..c33be3b155 100644
> > --- a/lib/cryptodev/rte_crypto_asym.h
> > +++ b/lib/cryptodev/rte_crypto_asym.h
> > @@ -306,7 +306,7 @@ struct rte_crypto_rsa_xform {
> >
> > enum rte_crypto_rsa_priv_key_type key_type;
> >
> > - union {
> > + struct {
> > rte_crypto_uint d;
> > /**< the RSA private exponent */
> > struct rte_crypto_rsa_priv_key_qt qt;
> > --
> > 2.21.0
>
> Acked-by: Arkadiusz Kusztal <arkadiuszx.kusz...@intel.com>
