On Tue, 1 Oct 2024 10:17:17 +0200
Robin Jarry <rja...@redhat.com> wrote:
> Replace ad-hoc uint8_t[16] array types in the API of rte_fib6, rte_rib6
> and rte_lpm6. Update all code accordingly.
>
> Unfortunately, these three libraries are strongly intertwined, it is not
> possible to split this change in separate commits.
>
> Signed-off-by: Robin Jarry <rja...@redhat.com>
> ---
>
> Notes:
> v2: updated changelog for 24.11
>
> app/test-fib/main.c | 51 +-
> app/test-pipeline/pipeline_lpm_ipv6.c | 10 +-
> app/test/test_fib6.c | 52 +-
> app/test/test_fib6_perf.c | 8 +-
> app/test/test_lpm6.c | 523 +++---
> app/test/test_lpm6_data.h | 2025 ++++++++++++------------
> app/test/test_lpm6_perf.c | 10 +-
> app/test/test_rib6.c | 65 +-
> app/test/test_table_combined.c | 2 +-
> app/test/test_table_tables.c | 8 +-
> doc/guides/rel_notes/deprecation.rst | 20 -
> doc/guides/rel_notes/release_24_11.rst | 2 +
> examples/ip_fragmentation/main.c | 24 +-
> examples/ip_pipeline/thread.c | 2 +-
> examples/ip_reassembly/main.c | 24 +-
> examples/ipsec-secgw/ipsec_lpm_neon.h | 7 +-
> examples/ipsec-secgw/ipsec_worker.c | 6 +-
> examples/ipsec-secgw/ipsec_worker.h | 4 +-
> examples/ipsec-secgw/rt.c | 22 +-
> examples/l3fwd/l3fwd_fib.c | 39 +-
> examples/l3fwd/l3fwd_lpm.c | 8 +-
> examples/l3fwd/l3fwd_route.h | 7 +-
> examples/l3fwd/lpm_route_parse.c | 6 +-
> lib/fib/meson.build | 4 +-
> lib/fib/rte_fib6.c | 13 +-
> lib/fib/rte_fib6.h | 11 +-
> lib/fib/trie.c | 99 +-
> lib/fib/trie.h | 16 +-
> lib/fib/trie_avx512.c | 38 +-
> lib/fib/trie_avx512.h | 10 +-
> lib/lpm/meson.build | 1 +
> lib/lpm/rte_lpm6.c | 106 +-
> lib/lpm/rte_lpm6.h | 14 +-
> lib/node/ip6_lookup.c | 16 +-
> lib/rib/meson.build | 2 +-
> lib/rib/rte_rib6.c | 74 +-
> lib/rib/rte_rib6.h | 13 +-
> lib/table/rte_table_lpm_ipv6.c | 12 +-
> lib/table/rte_table_lpm_ipv6.h | 4 +-
> 39 files changed, 1683 insertions(+), 1675 deletions(-)
>
> diff --git a/app/test-fib/main.c b/app/test-fib/main.c
> index c49bfe8bcec3..a43a0ae4df5d 100644
> --- a/app/test-fib/main.c
> +++ b/app/test-fib/main.c
> @@ -123,7 +123,7 @@ struct rt_rule_4 {
> };
>
> struct rt_rule_6 {
> - uint8_t addr[16];
> + struct rte_ipv6_addr addr;
> uint8_t depth;
> uint64_t nh;
> };
> @@ -306,15 +306,15 @@ shuffle_rt_6(struct rt_rule_6 *rt, int n)
>
> for (i = 0; i < n; i++) {
> j = rte_rand() % n;
> - memcpy(tmp.addr, rt[i].addr, 16);
> + memcpy(&tmp.addr, &rt[i].addr, 16);
Yet more places where memcpy should be replaced by assignment.
