On 10/3/2024 8:12 PM, Stephen Hemminger wrote: > On Wed, 17 Apr 2024 14:24:00 +0100 > Ferruh Yigit <ferruh.yi...@amd.com> wrote: > >>> :) remove compile flag in 24.11 LTS. >>> >>> But we may end up in same situation in 24.11, some drivers not being >>> ready, so we should merge this patch very early in the 24.11 to give >>> time to drivers to fix if they were not ready at that time. >>> >>> Other option is merge this patch in 24.07, so that vendors which were >>> not ready can plan a fix for 24.11? Although enforcing an update by >>> breaking the driver is not best planning, it may be an efficient one. >>> >> >> Hi Thomas and et al. , >> >> Is is good time to merge this patch, there is enough time to fix >> potential issues in this release, what do you think? > > Patch needs rebase if going into 24.11 >
Indeed we talked about this in the release status meeting this morning, as we discussed similar issue with Huisong [1]. If we will continue with the patch it should be merged before -rc1, so that drivers can fix any impact from it. Some options I can think of: 1. Move `RTE_LIBRTE_IEEE1588` macro to `config/rte_config.h`, so make it a little more configurable and keep macro (easiest, but not preferable). 2. Add a new meson config option to 'config/rte_config.h' to set/unset this macro, keep macro as it is. 3. Remove the macro, replace it with device argument per driver. So make it dynamically configured instead of build time. 4. Remove the macro, introduce a new offload flag (Huisong has similar patch [2]) for user to explicitly request this feature. 5. Remove the macro, implicitly enable it in the driver when vector path is not enabled. So feature will be always on for scalar path, always off for the vector path. User can disable vector path (RTE_VECT_SIMD_DISABLED) to enable PTP. Question is, will drivers have enough time form -rc1 to end of the release to fix drivers? Drivers in questions are: txgbe ngbe ixgbe i40e igb fm10k bnxt dpaa2 cnxk Can maintainers of the above drivers please comment? [1] https://inbox.dpdk.org/dev/1240fd64-ba5d-4dcc-b825-851da25b8...@amd.com/ [2] https://patches.dpdk.org/project/dpdk/patch/20240130035820.29713-1-lihuis...@huawei.com/
