On Tue, Oct 01, 2024 at 02:54:49PM +0100, Bruce Richardson wrote: > On Fri, Sep 20, 2024 at 06:05:59PM +0800, Zhichao Zeng wrote: > > This patch adds support for customizing firmware search path for > > DDP package like the kernel behavior, it will read the search path > > from "/sys/module/firmware_class/parameters/path", and try to load > > DDP package. > > > > Also, updates documentation for loading the DDP package in ice.rst. > > > > Signed-off-by: Zhichao Zeng <zhichaox.z...@intel.com> > > > > --- > > v6: use open() instead of fopen() > > v5: update documentation, fix code logic > > v4: fix CI error > > v3: update doc, fix code error > > v2: separate the patch and rewrite the log > > --- > > doc/guides/nics/ice.rst | 60 +++++++++++++++++++----------------- > > drivers/net/ice/ice_ethdev.c | 47 ++++++++++++++++++++++++++-- > > drivers/net/ice/ice_ethdev.h | 1 + > > 3 files changed, 76 insertions(+), 32 deletions(-) > > > > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst > > index ae975d19ad..a6104db4d4 100644 > > --- a/doc/guides/nics/ice.rst > > +++ b/doc/guides/nics/ice.rst > > @@ -80,6 +80,37 @@ are listed in the Tested Platforms section of the > > Release Notes for each release > > | 24.03 | 1.13.7 | 1.3.35 | 1.3.45 | 1.3.13 > > | 4.4 | > > > > +-----------+---------------+-----------------+-----------+--------------+-----------+ > > > > +Dynamic Device Personalization (DDP) package loading > > +---------------------------------------------------- > > + > > +The Intel E810 requires a programmable pipeline package be downloaded > > +by the driver to support normal operations. The E810 has limited > > +functionality built in to allow PXE boot and other use cases, but for DPDK > > use > > +the driver must download a package file during the driver initialization > > +stage. > > + > Minor nit - when writing documentation, rather than wrapping the lines at a > fixed column width, it is better to wrap on punctuation and to always start > a sentence on a new line. This reduces the diffs when editing documentation > in future. > > In this case, I'll just adjust the line-wrapping on apply, so no need for a > new revision of the patch. >
Acked-by: Bruce Richardson <bruce.richard...@intel.com> Patch applied to dpdk-next-net-intel. Thanks, /Bruce
