On Thu, Sep 19, 2024 at 8:35 AM Juraj Linkeš <juraj.lin...@pantheon.tech> wrote: > > > diff --git a/dts/framework/remote_session/testpmd_shell.py > > b/dts/framework/remote_session/testpmd_shell.py > > > @@ -577,6 +577,497 @@ class TestPmdPortStats(TextParser): > > tx_bps: int = field(metadata=TextParser.find_int(r"Tx-bps:\s+(\d+)")) > > > > > > +class PacketOffloadFlag(Flag): > > + """Flag representing the Packet Offload Features Flags in DPDK. > > + > > + Values in this class are taken from the definitions in the RTE MBUF > > core library in DPDK > > + located in lib/mbuf/rte_mbuf_core.h. It is expected that flag values > > in this class will match > > Another minor improvement: we should put the file path into double > backticks. Looking at DPDK docs, that's what they use for file paths, so > ``lib/mbuf/rte_mbuf_core.h``.
good idea, I didn't know there was already a format for doing this. > > There's also a References section that supported by google docstrings. I > don't know exactly what to put in it, but I'll try to use it in my > patch. I imagine a list of files (or functions) would be useful - we > could put the DPDK sources and testpmd functions that are relevant there. I'll have to read about this as well, I didn't know that was a thing either :). >
