Re: [PATCH v23 05/15] eal: do not duplicate rte_init_alert() messages

[fengchengwen]

Acked-by: Chengwen Feng <fengcheng...@huawei.com>

On 2024/9/18 12:56, Stephen Hemminger wrote:
> The message already goes through logging, and does not need
> to be printed on stderr. Message level should be ALERT
> to match function name.
> 
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> Acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>
> Acked-by: Morten Brørup <m...@smartsharesystems.com>
> ---
>  lib/eal/freebsd/eal.c | 3 +--
>  lib/eal/linux/eal.c   | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
> index d3b40e81d8..7b974608e4 100644
> --- a/lib/eal/freebsd/eal.c
> +++ b/lib/eal/freebsd/eal.c
> @@ -529,8 +529,7 @@ rte_eal_iopl_init(void)
>  
>  static void rte_eal_init_alert(const char *msg)
>  {
> -     fprintf(stderr, "EAL: FATAL: %s\n", msg);
> -     EAL_LOG(ERR, "%s", msg);
> +     EAL_LOG(ALERT, "%s", msg);
>  }
>  
>  /* Launch threads, called at application init(). */
> diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
> index 0ded386472..7c26393d00 100644
> --- a/lib/eal/linux/eal.c
> +++ b/lib/eal/linux/eal.c
> @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void)
>  
>  static void rte_eal_init_alert(const char *msg)
>  {
> -     fprintf(stderr, "EAL: FATAL: %s\n", msg);
> -     EAL_LOG(ERR, "%s", msg);
> +     EAL_LOG(ALERT, "%s", msg);
>  }
>  
>  /*