On 5. 7. 2024 19:13, Nicholas Pratte wrote:
The 'arch' attribute in the conf.yaml is unnecessary, as this can be
readily discovered within the constructor of any given node. Since OS is
determined within user configuration, finding system arch can be done
both reliably and easily within the framework.

For Linux/Posix systems, the 'uname' command is used to determine system
architecture. I believe that this is posix-standard and utilizes a
standardized output.

From what I can tell, uname is it POSIX compliant. Let's reword this to remove the uncertainty.

diff --git a/dts/framework/testbed_model/os_session.py 
b/dts/framework/testbed_model/os_session.py
index 79f56b289b..02277eee1f 100644
--- a/dts/framework/testbed_model/os_session.py
+++ b/dts/framework/testbed_model/os_session.py
@@ -342,6 +342,14 @@ def get_node_info(self) -> NodeInfo:
              Node information.
          """
+ @abstractmethod
+    def get_arch_info(self) -> str:

I'd rename this to just get_arch(), as get_arch_info implies we're getting more than just a string representation of the archirecture.

+        """Discover CPU architecture of the remote host.

The CPU architecture

Reply via email to