Just one comment here but it is a super small doc-string thing that still passes the formatting script and everything, but whenever we add Ruff for checking format in the future, it would get caught so it might be better to just add it now. Otherwise:
Reviewed-by: Jeremy Spewock <jspew...@iol.unh.edu> On Mon, Aug 26, 2024 at 5:22 PM Dean Marx <dm...@iol.unh.edu> wrote: <snip> > + def setup_hw_offload(self, testpmd: TestPmdShell) -> None: > + """Sets IP, UDP, TCP, and SCTP layers to hardware offload.""" Since this is a public method and it also has an argument, I think that it should follow the Google doc-string format and have an Args: section for it. > + testpmd.port_stop(port=0) > + offloads = ( > + ChecksumOffloadOptions.ip > + | ChecksumOffloadOptions.udp > + | ChecksumOffloadOptions.tcp > + | ChecksumOffloadOptions.sctp > + ) > + testpmd.csum_set_hw(layer=offloads, port_id=0) > + testpmd.port_start(port=0) > + <snip> >
