On 30. 7. 2024 15:28, Thomas Monjalon wrote:
12/07/2024 10:57, Juraj Linkeš:
The Sphinx script argument parsing improvement gives us more
flexibility going forward, such as the ability to add non-positional
arguments.
You should describe what is changed and why.
The Sphinx script argument parsing improvement gives us more
flexibility going forward, such as the ability to add non-positional
arguments. What is currently missing is the ability to define an
argument with default value, which is added here.
The other change just cleans up the code a bit, replacing the path:
dpdk_build_root/doc/api
with
meson.current_build_dir(),
which is the same, as it's called in the above dir that was previously
hardcoded.
-release = environ.setdefault('DPDK_VERSION', "None")
-version = release
+version = environ.setdefault('DPDK_VERSION', "None")
I'm quite sure "release" was set for a reason.
Did it change over time with recent Sphinx?
I looked at the docs and it didn't. I didn't realize this was a Sphinx
setting. I'll revert this.
