From: Jeremy Spewock <jspew...@iol.unh.edu>
The current implementation of consuming output from interactive shells
relies on being able to find an expected prompt somewhere within the
output buffer after sending the command. This is useful in situations
where the prompt does not appear in the output itself, but in some
practical cases (such as the starting of an XML-RPC server for scapy)
the prompt exists in one of the commands sent to the shell and this can
cause the command to exit early and creates a race condition between the
server starting and the first command being sent to the server.
This patch addresses this problem by searching for a line that strictly
ends with the provided prompt, rather than one that simply contains it,
so that the detection that a command is finished is more consistent. It
also adds a catch to detect when a command times out before finding the
prompt or the underlying SSH session dies so that the exception can be
wrapped into a more explicit one and be more consistent with the
non-interactive shells.
Bugzilla ID: 1359
Fixes: 88489c0501af ("dts: add smoke tests")
Signed-off-by: Jeremy Spewock <jspew...@iol.unh.edu>
Reviewed-by: Juraj Linkeš <juraj.lin...@pantheon.tech>
Reviewed-by: Luca Vizzarro <luca.vizza...@arm.com>
Reviewed-by: Nicholas Pratte <npra...@iol.unh.edu>
---
dts/framework/exception.py | 66 ++++++++++++-------
.../single_active_interactive_shell.py | 49 ++++++++++----
2 files changed, 79 insertions(+), 36 deletions(-)
diff --git a/dts/framework/exception.py b/dts/framework/exception.py
index 74fd2af3b6..f45f789825 100644
--- a/dts/framework/exception.py
+++ b/dts/framework/exception.py
@@ -51,26 +51,6 @@ class DTSError(Exception):
severity: ClassVar[ErrorSeverity] = ErrorSeverity.GENERIC_ERR
-class SSHTimeoutError(DTSError):
- """The SSH execution of a command timed out."""
-
- #:
- severity: ClassVar[ErrorSeverity] = ErrorSeverity.SSH_ERR
- _command: str
-
- def __init__(self, command: str):
- """Define the meaning of the first argument.
-
- Args:
- command: The executed command.
- """
- self._command = command
-
- def __str__(self) -> str:
- """Add some context to the string representation."""
- return f"{self._command} execution timed out."
-
-
class SSHConnectionError(DTSError):
"""An unsuccessful SSH connection."""
@@ -98,8 +78,42 @@ def __str__(self) -> str:
return message
-class SSHSessionDeadError(DTSError):
- """The SSH session is no longer alive."""
+class _SSHTimeoutError(DTSError):
+ """The execution of a command via SSH timed out.
+
+ This class is private and meant to be raised as its interactive and
non-interactive variants.
+ """
+
+ #:
+ severity: ClassVar[ErrorSeverity] = ErrorSeverity.SSH_ERR
+ _command: str
+
+ def __init__(self, command: str):
+ """Define the meaning of the first argument.
+
+ Args:
+ command: The executed command.
+ """
+ self._command = command
+
+ def __str__(self) -> str:
+ """Add some context to the string representation."""
+ return f"{self._command} execution timed out."
+
+
+class SSHTimeoutError(_SSHTimeoutError):
+ """The execution of a command on a non-interactive SSH session timed
out."""
+
+
+class InteractiveSSHTimeoutError(_SSHTimeoutError):
+ """The execution of a command on an interactive SSH session timed out."""
+
+
+class _SSHSessionDeadError(DTSError):
+ """The SSH session is no longer alive.
+
+ This class is private and meant to be raised as its interactive and
non-interactive variants.
+ """
#:
severity: ClassVar[ErrorSeverity] = ErrorSeverity.SSH_ERR
@@ -118,6 +132,14 @@ def __str__(self) -> str:
return f"SSH session with {self._host} has died."
+class SSHSessionDeadError(_SSHSessionDeadError):
+ """Non-interactive SSH session has died."""
+
+
+class InteractiveSSHSessionDeadError(_SSHSessionDeadError):
+ """Interactive SSH session as died."""
+
+
class ConfigurationError(DTSError):
"""An invalid configuration."""
diff --git a/dts/framework/remote_session/single_active_interactive_shell.py
b/dts/framework/remote_session/single_active_interactive_shell.py
index 38094c0fe2..0e5a04885f 100644
--- a/dts/framework/remote_session/single_active_interactive_shell.py
+++ b/dts/framework/remote_session/single_active_interactive_shell.py
@@ -27,7 +27,11 @@
from paramiko import Channel, channel # type: ignore[import-untyped]
from typing_extensions import Self
-from framework.exception import InteractiveCommandExecutionError
+from framework.exception import (
+ InteractiveCommandExecutionError,
+ InteractiveSSHSessionDeadError,
+ InteractiveSSHTimeoutError,
+)
from framework.logger import DTSLogger
from framework.params import Params
from framework.settings import SETTINGS
@@ -71,7 +75,10 @@ class SingleActiveInteractiveShell(ABC):
#: Extra characters to add to the end of every command
#: before sending them. This is often overridden by subclasses and is
- #: most commonly an additional newline character.
+ #: most commonly an additional newline character. This additional newline
+ #: character is used to force the line that is currently awaiting input
+ #: into the stdout buffer so that it can be consumed and checked against
+ #: the expected prompt.
_command_extra_chars: ClassVar[str] = ""
#: Path to the executable to start the interactive application.
@@ -175,6 +182,9 @@ def send_command(
Raises:
InteractiveCommandExecutionError: If attempting to send a command
to a shell that is
not currently running.
+ InteractiveSSHSessionDeadError: The session died while executing
the command.
+ InteractiveSSHTimeoutError: If command was sent but prompt could
not be found in
+ the output before the timeout.
"""
if not self.is_alive:
raise InteractiveCommandExecutionError(
@@ -183,19 +193,30 @@ def send_command(
self._logger.info(f"Sending: '{command}'")
if prompt is None:
prompt = self._default_prompt
- self._stdin.write(f"{command}{self._command_extra_chars}\n")
- self._stdin.flush()
out: str = ""
- for line in self._stdout:
- if skip_first_line:
- skip_first_line = False
- continue
- if prompt in line and not line.rstrip().endswith(
- command.rstrip()
- ): # ignore line that sent command
- break
- out += line
- self._logger.debug(f"Got output: {out}")
+ try:
+ self._stdin.write(f"{command}{self._command_extra_chars}\n")
+ self._stdin.flush()
+ for line in self._stdout:
+ if skip_first_line:
+ skip_first_line = False
+ continue
+ if line.rstrip().endswith(prompt):
+ break
+ out += line
+ except TimeoutError as e:
+ self._logger.exception(e)
+ self._logger.debug(
+ f"Prompt ({prompt}) was not found in output from command
before timeout."
+ )
+ raise InteractiveSSHTimeoutError(command) from e
+ except OSError as e:
+ self._logger.exception(e)
+ raise InteractiveSSHSessionDeadError(
+ self._node.main_session.interactive_session.hostname
+ ) from e
+ finally:
+ self._logger.debug(f"Got output: {out}")
return out
def _close(self) -> None:
--
2.45.2
