On Tue, Jul 23, 2024 at 02:17:22PM +0100, Bruce Richardson wrote:
> On Tue, Jul 23, 2024 at 02:10:56PM +0100, Anatoly Burakov wrote:
> > Currently, we manually set PHY model in `ice_dev_init`, however we missed
> > adding case for E830, so for E830 the initialization ends up calling E822
> > code instead. This results in incorrect phy model being set and having
> > several downstream consequences for E830 as a result, ranging from a
> > stray error message from attempting to start PHY timer, and up to
> > inability to enable timesync on E830 devices.
> >
> > We could've fixed it by adding a case for E830, however there are several
> > other missing bits of initialization (such as `phy_ports` field). All of
> > this can be fixed by replacing manual setting of `phy_model` with a call
> > to `ice_ptp_init_phy_model()`, which calls into base code and initializes
> > the fields appropriately for all device types, including another option
> > that is missing from current implementation - ETH56G.
> >
> > Fixes: c3bedb7114f2 ("net/ice/base: add E830 PTP initialization")
> >
> > Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
>
> Reviewed-by: Bruce Richardson <bruce.richard...@intel.com>
>
Applied to dpdk-next-net-intel
Thanks,
/Bruce
