[PATCH v4 009/103] net/ice/base: fix resource leak

[Anatoly Burakov]

From: Fabio Pricoco <fabio.pric...@intel.com>

When errors happen during OROM reads, the allocated buffer is not freed.
Fix it by adding a goto label to free the buffer in case of error.
Signed-off-by: Fabio Pricoco <fabio.pric...@intel.com>
Signed-off-by: Ian Stokes <ian.sto...@intel.com>
---
 drivers/net/ice/base/ice_nvm.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ice/base/ice_nvm.c b/drivers/net/ice/base/ice_nvm.c
index 9cebe7a07b..55e624cb31 100644
--- a/drivers/net/ice/base/ice_nvm.c
+++ b/drivers/net/ice/base/ice_nvm.c
@@ -748,7 +748,7 @@ ice_get_orom_civd_data(struct ice_hw *hw, enum 
ice_bank_select bank,
                                       orom_data, hw->flash.banks.orom_size);
        if (status) {
                ice_debug(hw, ICE_DBG_NVM, "Unable to read Option ROM data\n");
-               return status;
+               goto exit_error;;
        }
 
        /* Scan the memory buffer to locate the CIVD data section */
@@ -772,7 +772,8 @@ ice_get_orom_civd_data(struct ice_hw *hw, enum 
ice_bank_select bank,
                if (sum) {
                        ice_debug(hw, ICE_DBG_NVM, "Found CIVD data with 
invalid checksum of %u\n",
                                  sum);
-                       goto err_invalid_checksum;
+                       status = ICE_ERR_NVM;
+                       goto exit_error;
                }
 
                *civd = *tmp;
@@ -780,11 +781,12 @@ ice_get_orom_civd_data(struct ice_hw *hw, enum 
ice_bank_select bank,
                return 0;
        }
 
+       status = ICE_ERR_NVM;
        ice_debug(hw, ICE_DBG_NVM, "Unable to locate CIVD data within the 
Option ROM\n");
 
-err_invalid_checksum:
+exit_error:
        ice_free(hw, orom_data);
-       return ICE_ERR_NVM;
+       return status;
 }
 
 /**
-- 
2.43.0