On Tue, 25 Jun 2024 17:29:35 +0200 Maxime Coquelin <maxime.coque...@redhat.com> wrote:
> Hi Mattias, > > On 6/20/24 19:57, Mattias Rönnblom wrote: > > This patch set make DPDK library, driver, and application code use the > > compiler/libc memcpy() by default when functions in <rte_memcpy.h> are > > invoked. > > > > The various custom DPDK rte_memcpy() implementations may be retained > > by means of a build-time option. > > > > This patch set only make a difference on x86, PPC and ARM. Loongarch > > and RISCV already used compiler/libc memcpy(). > > It indeed makes a difference on x86! > > Just tested latest main with and without your series on > Intel(R) Xeon(R) Gold 6438N. > > The test is a simple IO loop between a Vhost PMD and a Virtio-user PMD: > # dpdk-testpmd -l 4-6 --file-prefix=virtio1 --no-pci --vdev > 'net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,server=1,mrg_rxbuf=1,in_order=1' > > --single-file-segments -- -i > testpmd> start > > # dpdk-testpmd -l 8-10 --file-prefix=vhost1 --no-pci --vdev > 'net_vhost0,iface=vhost-net,client=1' --single-file-segments -- -i > testpmd> start tx_first 32 > > Latest main: 14.5Mpps > Latest main + this series: 10Mpps > > So for me, it should be disabled by default. > > Regards, > Maxime What is the size of the copy being done? Which compiler version?
