The argument is '--lcores' but it is being logged as '--lcore'
in several places.
e.g.
$ dpdk-testpmd -l 8,10,12 --lcores 8,10,12
EAL: Option --lcore is ignored, because (-l) is set!
Fix the spelling in logs and tests.
Fixes: 117eaa70584b ("eal: add error check for core options")
Signed-off-by: Kevin Traynor <ktray...@redhat.com>
---
app/test/test_eal_flags.c | 2 +-
lib/eal/common/eal_common_options.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 6cb4b06757..71d8dba731 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -672,5 +672,5 @@ test_missing_c_flag(void)
launch_proc(argv28) == 0 || launch_proc(argv30) == 0) {
printf("Error - "
- "process ran without error with invalid --lcore flag\n");
+ "process ran without error with invalid --lcores
flag\n");
return -1;
}
diff --git a/lib/eal/common/eal_common_options.c
b/lib/eal/common/eal_common_options.c
index e541f07939..f1a5e329a5 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -1688,5 +1688,5 @@ eal_parse_common_option(int opt, const char *optarg,
EAL_LOG(ERR, "Option -c is ignored, because (%s) is
set!",
(core_parsed == LCORE_OPT_LST) ? "-l" :
- (core_parsed == LCORE_OPT_MAP) ? "--lcore" :
+ (core_parsed == LCORE_OPT_MAP) ? "--lcores" :
"-c");
return -1;
@@ -1721,5 +1721,5 @@ eal_parse_common_option(int opt, const char *optarg,
EAL_LOG(ERR, "Option -l is ignored, because (%s) is
set!",
(core_parsed == LCORE_OPT_MSK) ? "-c" :
- (core_parsed == LCORE_OPT_MAP) ? "--lcore" :
+ (core_parsed == LCORE_OPT_MAP) ? "--lcores" :
"-l");
return -1;
@@ -1902,8 +1902,8 @@ eal_parse_common_option(int opt, const char *optarg,
if (core_parsed) {
- EAL_LOG(ERR, "Option --lcore is ignored, because (%s)
is set!",
+ EAL_LOG(ERR, "Option --lcores is ignored, because (%s)
is set!",
(core_parsed == LCORE_OPT_LST) ? "-l" :
(core_parsed == LCORE_OPT_MSK) ? "-c" :
- "--lcore");
+ "--lcores");
return -1;
}
--
2.45.0
