On 31. 5. 2024 23:08, Jeremy Spewock wrote:
On Fri, May 31, 2024 at 12:34 PM Luca Vizzarro <luca.vizza...@arm.com> wrote:
Due to the nature of this patch the console is spammed with a lot of
commands. Would it be better to log these in debug and instead log:
Setting port X to MTU XXXX
as INFO?
Potentially, but this would require a global change for how logging
works when sending commands to interactive shells in general. They are
each logged as their own message since they are each individual
commands being sent into the shell which (in general) we do want to
log. I could maybe add an optional flag to the send command function
that logs its output to debug rather than info however which might be
a nicer solution. I agree that it does get cluttered.
I think this would be suitable as a separate change; we should make a
bugzilla ticket. It's likely better to move these to debug and let
individual commands log as info the most important part if needed
(either using a switch or a separate log call).