BR Rongwei
> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Friday, June 7, 2024 21:26 > To: rongwei liu <rongw...@nvidia.com> > Cc: dev@dpdk.org; Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko > <viachesl...@nvidia.com>; Ori Kam <or...@nvidia.com>; Suanming Mou > <suanmi...@nvidia.com>; Dariusz Sosnowski <dsosnow...@nvidia.com>; > Aman Singh <aman.deep.si...@intel.com>; Yuying Zhang > <yuying.zh...@intel.com>; Ferruh Yigit <ferruh.yi...@amd.com>; Andrew > Rybchenko <andrew.rybche...@oktetlabs.ru> > Subject: Re: [PATCH v7 2/3] ethdev: add VXLAN last reserved field > > External email: Use caution opening links or attachments > > > 05/06/2024 15:04, Rongwei Liu: > > Add "uint8_t last_rsvd" as union with origin rsvd1. > > Add RTE_FLOW_FIELD_VXLAN_LAST_RSVD into rte flow packet field. > > > > The new union is used by testpmd matching item VXLAN "last_rsvd" > > no it is still using the name "rsvd1" in testpmd > Map the testpmd cli "last_rsvd" to the new entry "last_rsvd" Keep the vxlan-gpe as the original since it refers to rte_vxlan_gpe_hdr not rte_vxlan_hdr. "rsvd1" string: I though you are talking about the vxlan-gpe not vxlan. If we plan to change this too, another commit is desired. > > and modify target "vxlan_last_rsvd". > > You should give the real name: RTE_FLOW_FIELD_VXLAN_LAST_RSVD ACK > > With above changes, > Acked-by: Thomas Monjalon <tho...@monjalon.net> > > > Signed-off-by: Rongwei Liu <rongw...@nvidia.com> > > Acked-by: Dariusz Sosnowski <dsosnow...@nvidia.com> > >
