> > Subject: RE: [EXTERNAL] [PATCH v1] crypto: fix build issues on crypto > > callbacks > > macro undefined > > > > > Crypto callbacks macro is defined with value 1 and being used with > > > ifdef, on config value is changed to 0 to disable, crypto callback > > > changes still being compiled. > > > > I believe we can use #if instead of ifdefs. > > It seems convenient to enable/disable in my opinion. > > We can use both, but whatever we use should be same as that for ethdev > > callbacks. > > > Using #if requires check for equality like > #if RTE_CRYPTO_CALLBACKS == 1 for a macro defined with value 1
No If it is set as 0, it will be disabled, else for any other value it will be enabled. No need for check. Right? > > > The same issue would be for ethdev callbacks too. > > Ferruh, can you check?
