On Tue, May 14, 2024 at 7:34 AM Luca Vizzarro <luca.vizza...@arm.com> wrote:
> diff --git a/dts/framework/runner.py b/dts/framework/runner.py
> index db8e3ba96b..d74f1871db 100644
> --- a/dts/framework/runner.py
> +++ b/dts/framework/runner.py
> @@ -23,7 +23,7 @@
> import re
> import sys
> from pathlib import Path
> -from types import MethodType
> +from types import FunctionType
> from typing import Iterable, Sequence
>
> from .config import (
> @@ -132,8 +132,8 @@ def run(self):
> the :option:`--test-suite` command line argument or
> the :envvar:`DTS_TESTCASES` environment variable.
> """
> - sut_nodes: dict[str, SutNode] = {}
> - tg_nodes: dict[str, TGNode] = {}
> + sut_nodes = {}
> + tg_nodes = {}
I think this is fine. Another option would be to move sut_nodes and
tg_nodes up as DTSRunner attributes. I like preserving the type hint,
but it also might just be cluttering the code to do this... up to you.
But overall I think it is good and I ran the mypy type check from this patch.
Reviewed-by: Patrick Robb <pr...@iol.unh.edu>
Tested-by: Patrick Robb <pr...@iol.unh.edu>
