Hi Abdullah,
Few comments inline
> On Apr 17, 2024, at 8:39 AM, Abdullah Ömer Yamaç <aomerya...@gmail.com> wrote:
>
> In the previous implementation, the maximum reclamation size was set
> to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch
> uses the configuration argument to set the maximum reclamation size.
Nit. This can be as follows:
“Set the maximum reclamation size to user provided value”
>
> Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation")
> Cc: dharmik.thak...@arm.com
> Cc: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
> Cc: Yipeng Wang <yipeng1.w...@intel.com>
> Cc: Sameh Gobriel <sameh.gobr...@intel.com>
> Cc: Bruce Richardson <bruce.richard...@intel.com>
> Cc: Vladimir Medvedkin <vladimir.medved...@intel.com>
Please add:
sta...@dpdk.org to the Cc list
>
> Signed-off-by: Abdullah Ömer Yamaç <aomerya...@gmail.com>
> ---
> lib/hash/rte_cuckoo_hash.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> index 4a44aadd9a..6d80793164 100644
> --- a/lib/hash/rte_cuckoo_hash.c
> +++ b/lib/hash/rte_cuckoo_hash.c
> @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct
> rte_hash_rcu_config *cfg)
> if (params.size == 0)
> params.size = total_entries;
> params.trigger_reclaim_limit = cfg->trigger_reclaim_limit;
> + params.max_reclaim_size = cfg->max_reclaim_size;
> if (params.max_reclaim_size == 0)
> params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX;
> params.esize = sizeof(struct __rte_hash_rcu_dq_entry);
> --
> 2.34.1
>
