On Tue, Oct 27, 2015 at 10:15:01AM +0800, Yuanhan Liu wrote: > On Tue, Oct 27, 2015 at 01:44:09AM +0000, Tan, Jianfeng wrote: > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Huawei Xie > > > Sent: Sunday, October 25, 2015 11:35 PM > > > To: dev at dpdk.org > > > Subject: [dpdk-dev] [PATCH v5 0/7] virtio ring layout optimization and > > > simple > > > rx/tx processing > > > > > > Changes in v5: > > > - Call __rte_pktmbuf_prefree_seg to check refcnt when free mbufs > > > > > > Changes in v4: > > > - Fix the error in virtio tx ring layout ascii chart in the commit message > > > - Move virtio_xmit_cleanup ahead to free descriptors earlier > > > - Test merge-able feature when select simple rx/tx functions > > [...] > > > > > Acked-by Jianfeng Tan <jianfeng.tan at intel.com> > > Jianfeng, > > I often see a reply like this, just dropping an ACK at the end of > long email, and no more, which takes me (as well as others) some > time to scroll it many times to the bottom till see that. > > TBH, it's always a bit frustrating that, after the scroll effort, > I just see such a reply that could have been put on the top of > the email so that I can see it with a glimpse only. > > So, top reply would be good for this case, or you could reply like > what I did, removing other context to make your reply fit in one > screen. > > --yliu
+1 When ack'ing patches, please place the ack on the line underneath the signoff and delete the rest of the email below, as it's unneeded. /Bruce
