On Fri, May 03, 2024 at 02:12:58PM +0100, Tom Jones wrote: > Hi Bruce, > > thanks for letting me know > > I'm not tied to anything particularly. This change isn't compatible with the > previous API, but I'm not against making it so if that is really the best > thing to do. As is, the dpdk changes and the contigmem changes need to come > together because the API changes for getting the physical addresses. >
I don't think it's a major problem if the new kernel code doesn't work with the older DPDK userspace code, we can apply both together in one patch. However, it would count as an API/ABI change so would need to be deferred for merge to 24.11 release, I think. > It is just the sysctl paths that differ. I'm not sure what the compatibility > needs to be for DPDK, for all of my usage I have built the kernel module with > the package - making API changes easy. > > I'm happy to follow which ever path you think is best. > I'll maybe give more thoughts on this once I try the patch out. Hopefully I'll get to test it out this afternoon. Don't bother trying to rework anything until then! :-) > Sorry for the patch confusion, I'll try to keep the sequence obvious going > forward. > No problem. Thanks for the contribution here. FreeBSD support has sadly been lacking a number of features for some time now, so all changes to close the feature gap vs linux are very welcome! /Bruce
