On Wed, May 01, 2024 at 10:19:54AM +0200, Thomas Monjalon wrote: > Hello Ian, > > In general, base drivers are updated with multiple commits, one per feature. > It helps tracking the changes. > > Please would it be possible to split? >
Hi Thomas, yes, that is very much the intention. As Ian states in his last line, we sent this as an RFC to a) flag that the series is coming in future, and b) have an initial CI run done, while we work in parallel on splitting the code changes into a more meaningful series of commits. Given the scope of the changes we didn't have time to do the split yet, but wanted to get an inital RFC to the list. /Bruce > PS: look like you are not registered in the mailing list, > this patch was in the moderation queue. > > > 30/04/2024 17:40, Ian Stokes: > > The purpose of this patch is to update shared code for the ice driver. > > This patch not only contains the updated base code files but also the > > required changes within the DPDK code base to enable compilation and > > basic functionality. This is with a view to allow further regression > > testing while a final patch series is generated that correctly splits > > the code changes into an expected manner. > > > > Signed-off-by: Ian Stokes <ian.sto...@intel.com> > > --- > > drivers/net/ice/base/ice_acl.c | 58 +- > > drivers/net/ice/base/ice_acl.h | 50 +- > > drivers/net/ice/base/ice_acl_ctrl.c | 45 +- > > drivers/net/ice/base/ice_adminq_cmd.h | 459 ++- > > drivers/net/ice/base/ice_bitops.h | 8 +- > > drivers/net/ice/base/ice_cgu_regs.h | 90 + > > drivers/net/ice/base/ice_common.c | 1621 +++++--- > > drivers/net/ice/base/ice_common.h | 189 +- > > drivers/net/ice/base/ice_controlq.c | 213 +- > > drivers/net/ice/base/ice_controlq.h | 28 +- > > drivers/net/ice/base/ice_dcb.c | 79 +- > > drivers/net/ice/base/ice_dcb.h | 32 +- > > drivers/net/ice/base/ice_ddp.c | 115 +- > > drivers/net/ice/base/ice_ddp.h | 18 +- > > drivers/net/ice/base/ice_devids.h | 39 +- > > drivers/net/ice/base/ice_fdir.c | 50 +- > > drivers/net/ice/base/ice_fdir.h | 18 +- > > drivers/net/ice/base/ice_flex_pipe.c | 385 +- > > drivers/net/ice/base/ice_flex_pipe.h | 32 +- > > drivers/net/ice/base/ice_flex_type.h | 41 +- > > drivers/net/ice/base/ice_flow.c | 337 +- > > drivers/net/ice/base/ice_flow.h | 52 +- > > drivers/net/ice/base/ice_fwlog.c | 5 + > > drivers/net/ice/base/ice_fwlog.h | 4 + > > drivers/net/ice/base/ice_hw_autogen.h | 2569 ++++++++++-- > > drivers/net/ice/base/ice_lan_tx_rx.h | 87 +- > > drivers/net/ice/base/ice_metainit.c | 2 +- > > drivers/net/ice/base/ice_nvm.c | 321 +- > > drivers/net/ice/base/ice_nvm.h | 36 +- > > drivers/net/ice/base/ice_parser.c | 57 +- > > drivers/net/ice/base/ice_parser.h | 30 +- > > drivers/net/ice/base/ice_parser_rt.c | 88 +- > > drivers/net/ice/base/ice_parser_rt.h | 23 +- > > drivers/net/ice/base/ice_phy_regs.h | 84 + > > drivers/net/ice/base/ice_protocol_type.h | 17 +- > > drivers/net/ice/base/ice_ptp_consts.h | 3 +- > > drivers/net/ice/base/ice_ptp_hw.c | 4593 ++++++++++------------ > > drivers/net/ice/base/ice_ptp_hw.h | 332 +- > > drivers/net/ice/base/ice_sbq_cmd.h | 1 - > > drivers/net/ice/base/ice_sched.c | 556 +-- > > drivers/net/ice/base/ice_sched.h | 130 +- > > drivers/net/ice/base/ice_switch.c | 1893 +++++---- > > drivers/net/ice/base/ice_switch.h | 241 +- > > drivers/net/ice/base/ice_type.h | 194 +- > > drivers/net/ice/base/ice_vf_mbx.c | 4 + > > drivers/net/ice/base/ice_vf_mbx.h | 4 + > > drivers/net/ice/base/ice_vlan_mode.c | 47 +- > > drivers/net/ice/base/ice_vlan_mode.h | 2 +- > > drivers/net/ice/base/ice_xlt_kb.c | 4 +- > > drivers/net/ice/base/meson.build | 2 + > > drivers/net/ice/ice_diagnose.c | 9 +- > > drivers/net/ice/ice_ethdev.c | 55 +- > > 52 files changed, 9105 insertions(+), 6247 deletions(-) > > create mode 100644 drivers/net/ice/base/ice_fwlog.c > > create mode 100644 drivers/net/ice/base/ice_fwlog.h > > create mode 100644 drivers/net/ice/base/ice_phy_regs.h > > create mode 100644 drivers/net/ice/base/ice_vf_mbx.c > > create mode 100644 drivers/net/ice/base/ice_vf_mbx.h > > > > > > >
