On Thu, 25 Apr 2024 11:31:31 -0700 Tyler Retzlaff <roret...@linux.microsoft.com> wrote:
> On Thu, Apr 25, 2024 at 11:23:58AM -0700, Stephen Hemminger wrote: > > The string type is left over from first version of DPDK and > > was never implemented. > > > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > > --- > > lib/eal/include/rte_malloc.h | 21 +++++++-------------- > > 1 file changed, 7 insertions(+), 14 deletions(-) > > > > diff --git a/lib/eal/include/rte_malloc.h b/lib/eal/include/rte_malloc.h > > index 54a8ac211e..91c9214c57 100644 > > --- a/lib/eal/include/rte_malloc.h > > +++ b/lib/eal/include/rte_malloc.h > > @@ -37,8 +37,7 @@ struct rte_malloc_socket_stats { > > * NUMA socket as the core that calls this function. > > * > > * @param type > > - * A string identifying the type of allocated objects (useful for debug > > - * purposes, such as identifying the cause of a memory leak). Can be > > NULL. > > + * Legacy argument, never unused should be NULL. > > never unused seems unintended double negative. > > should it be 'unused' or 'never used' thanks