On 4/25/2024 4:08 PM, Mattias Rönnblom wrote: > On 2024-04-25 16:08, Ferruh Yigit wrote: >> On 4/23/2024 12:15 PM, Ferruh Yigit wrote: >>>> Signed-off-by: Mattias Rönnblom <mattias.ronnb...@ericsson.com> >>>> --- >>>> drivers/net/af_packet/rte_eth_af_packet.c | 5 +++-- >>>> 1 file changed, 3 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c >>>> b/drivers/net/af_packet/rte_eth_af_packet.c >>>> index 397a32db58..28aeb7d08e 100644 >>>> --- a/drivers/net/af_packet/rte_eth_af_packet.c >>>> +++ b/drivers/net/af_packet/rte_eth_af_packet.c >>>> @@ -6,6 +6,7 @@ >>>> * All rights reserved. >>>> */ >>>> +#include <rte_common.h> >>>> #include <rte_string_fns.h> >>>> #include <rte_mbuf.h> >>>> #include <ethdev_driver.h> >>>> @@ -53,7 +54,7 @@ struct pkt_rx_queue { >>>> volatile unsigned long rx_pkts; >>>> volatile unsigned long rx_bytes; >>>> -}; >>>> +} __rte_cache_aligned; >>>> >>> Latest location for '__rte_cache_aligned' tag is at the beginning of the >>> struct [1], so something like: >>> `struct __rte_cache_aligned pkt_rx_queue {` >>> >>> [1] >>> https://patchwork.dpdk.org/project/dpdk/list/?series=31746&state=%2A&archive=both >>> >> >> Hi Mattias, >> >> We dived into side discussions but with above change I can proceed with >> the patch. > > OK. > > Should this go into some stable branch as well? >
I don't see any reason for not merging to stable trees. For this please add fixes and stable tags.