On 4/16/2024 4:19 PM, Stephen Hemminger wrote: > Use RTE_DIM instead of computing directly with sizeof. > Patch automatically generated via cocci/rte_dim.cocci. > Code in base/ subdirectory manually excluded. > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> >
Updated ones looks good to me, but I can see a few more, I don't know if you excluded base file one intentionally, searched as `git grep "sizeof.*\[0\]" drivers/net/` - drivers/net/bnxt/tf_core/cfa_tcam_mgr.h:28:#define ARRAY_SIZE(_array) (sizeof(_array) / sizeof(_array[0])) - drivers/net/hinic/base/hinic_pmd_nicio.c:449: / sizeof(hinic_hw_rx_buf_size[0]); - drivers/net/ice/ice_ethdev.c:330:#define ICE_NB_MBUF_XSTATS (sizeof(ice_mbuf_strings) / sizeof(ice_mbuf_strings[0])) - drivers/net/i40e/i40e_ethdev.c:554:#define I40E_NB_MBUF_XSTATS (sizeof(i40e_mbuf_strings) / sizeof(i40e_mbuf_strings[0])) - drivers/net/i40e/base/i40e_adminq.h:126: if (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])))) - drivers/net/ipn3ke/ipn3ke_representor.c:506: / sizeof(ipn3ke_rpst_hw_port_strings[0])) drivers/net/ipn3ke/ipn3ke_representor.c:517: / sizeof(ipn3ke_rpst_rxq_prio_strings[0])) drivers/net/ipn3ke/ipn3ke_representor.c:530: / sizeof(ipn3ke_rpst_txq_prio_strings[0])) - drivers/net/ixgbe/base/ixgbe_x550.c:443: for (i = 0; i < sizeof(ixgbe_fw_map) / sizeof(ixgbe_fw_map[0]); ++i) { drivers/net/ixgbe/base/ixgbe_x550.c:700: for (i = 0; i < sizeof(ixgbe_fw_map) / sizeof(ixgbe_fw_map[0]); ++i) { - drivers/net/ixgbe/base/ixgbe_x550.c:3338: bufsz = sizeof(buf) / sizeof(buf[0]); - drivers/net/mlx5/hws/mlx5dr_internal.h:52:#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))