On Fri, Apr 12, 2024 at 4:43 PM Sebastian Brzezinka <sebastian.brzezi...@intel.com> wrote: > > From: Krishna Kanth Reddy <krish.re...@samsung.com> > > Modified the Configuration file to use the latest ARM Cross-Compiler. > > Fixed the linker errors for the undefined references to the APIs > isal_deflate_init, isal_deflate, isal_inflate_init, isal_inflate, > isal_inflate_stateless, isal_deflate_stateless, > isal_deflate_set_hufftables in the case of ARM Cross-Compilation. > > Signed-off-by: Krishna Kanth Reddy <krish.re...@samsung.com> > Signed-off-by: Sebastian Brzezinka <sebastian.brzezi...@intel.com>
There is comment[1] in v1. v2 is not addressed the comment nor provided any feedback. Also please add change log in patch(i.e what is changed from a version to another version) [1] https://patches.dpdk.org/project/dpdk/patch/20240405110700.3279213-1-sebastian.brzezi...@intel.com/ > --- > config/arm/arm64_armv8_linux_gcc | 10 +++++----- > drivers/compress/isal/meson.build | 4 ++++ > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/config/arm/arm64_armv8_linux_gcc > b/config/arm/arm64_armv8_linux_gcc > index 529694b49d..6dfb8aa206 100644 > --- a/config/arm/arm64_armv8_linux_gcc > +++ b/config/arm/arm64_armv8_linux_gcc > @@ -1,9 +1,9 @@ > [binaries] > -c = ['ccache', 'aarch64-linux-gnu-gcc'] > -cpp = ['ccache', 'aarch64-linux-gnu-g++'] > -ar = 'aarch64-linux-gnu-gcc-ar' > -strip = 'aarch64-linux-gnu-strip' > -pkgconfig = 'aarch64-linux-gnu-pkg-config' > +c = ['ccache', 'aarch64-none-linux-gnu-gcc'] > +cpp = ['ccache', 'aarch64-none-linux-gnu-cpp'] > +ar = 'aarch64-none-linux-gnu-gcc-ar' > +strip = 'aarch64-none-linux-gnu-strip' > +pkgconfig = 'aarch64-none-linux-gnu-pkg-config' > pcap-config = '' > > [host_machine] > diff --git a/drivers/compress/isal/meson.build > b/drivers/compress/isal/meson.build > index 4b3eaa2274..b3cc990053 100644 > --- a/drivers/compress/isal/meson.build > +++ b/drivers/compress/isal/meson.build > @@ -5,6 +5,10 @@ dep = dependency('libisal', required: false, method: > 'pkg-config') > if not dep.found() > build = false > reason = 'missing dependency, "libisal"' > + isal_dep = cc.find_library('libisal', required: false) > + if isal_dep.found() > + ext_deps += isal_dep > + endif > endif > > deps += 'bus_vdev' > -- > 2.34.1 >
