I have a general question. What are these changes for? Do you anticipate us needing this in the future? Wouldn't it be better to add it only when we need it?
On Thu, Mar 28, 2024 at 5:48 PM Jeremy Spewock <jspew...@iol.unh.edu> wrote: > > On Tue, Mar 26, 2024 at 3:04 PM Luca Vizzarro <luca.vizza...@arm.com> wrote: > <snip> > > diff --git a/dts/framework/remote_session/interactive_shell.py > > b/dts/framework/remote_session/interactive_shell.py > > index a2c7b30d9f..5d80061e8d 100644 > > --- a/dts/framework/remote_session/interactive_shell.py > > +++ b/dts/framework/remote_session/interactive_shell.py > > @@ -41,8 +41,10 @@ class InteractiveShell(ABC): > > _stdout: channel.ChannelFile > > _ssh_channel: Channel > > _logger: DTSLogger > > + __default_timeout: float > > Only single underscores are used for other private variables, probably > better to keep that consistent with this one. > I agree, I don't see a reason for the double underscore. > > _timeout: float > > _app_args: Params | None > > + _is_privileged: bool = False > <snip> > > 2.34.1 > >
