Re: [PATCH 1/8] net/ice: fix check for outer UDP checksum offload

[David Marchand]

On Fri, Apr 5, 2024 at 2:51 PM David Marchand <david.march...@redhat.com> wrote:
>
> ICE_TX_CTX_EIPT_NONE == 0.
> There is a good chance that !(anything & 0) is always true :-).

Note to self... rather than joking on a Friday afternoon, re test the
*whole* series.


> @@ -2751,7 +2751,7 @@ ice_parse_tunneling_params(uint64_t ol_flags,
>          * Calculate the tunneling UDP checksum.
>          * Shall be set only if L4TUNT = 01b and EIPT is not zero
>          */
> -       if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&
> +       if (!(*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) &&

Should be (*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M).


-- 
David Marchand