On Wed, Mar 20, 2024 at 4:56 PM Bruce Richardson <bruce.richard...@intel.com> wrote: > > On Wed, Mar 20, 2024 at 08:36:53AM -0700, Tyler Retzlaff wrote: > > The current location used for __rte_aligned(a) for alignment of types > > and variables is not compatible with MSVC. There is only a single > > location accepted by both toolchains. > > > > After having established this as the conventional standard for lib/* > > this series is intended to convert the remainder of the source tree to > > use the same location for __rte_aligned(a) and alignas(a) for > > consistency. > > > No objection to this change. Is there a checkpatch rule available to > enforce this going forward or how can we avoid future introduction of > macros in the wrong place?
We added one in v24.03, it is not perfect, but it should help catch most. https://git.dpdk.org/dpdk/commit/devtools?id=c6552d9a8deffa448de2d5e2e726f50508c1efd2 -- David Marchand