2015-10-23 09:03, Stephen Hemminger: > Thomas Monjalon <thomas.monjalon at 6wind.com> wrote: > > +options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ > > +VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,\ > > +SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > > +NEW_TYPEDEFS,COMPLEX_MACRO,COMPARISON_TO_NULL" > > Please keep some of these: > PARENTHESIS_ALIGNMENT
It is not written in the DPDK coding rules that "Alignment should match open parenthesis" > LINUX_VERSION_CODE It is used for out-of-tree modules. > COMPLEX_MACRO I don't remember why I've ignored this one: "Macros with complex values should be enclosed in parentheses" > All of these are indications of problems in code. I don't think so for the DPDK case, except COMPLEX_MACRO. Thanks for catching.
