On Sun, Mar 10, 2024 at 8:35 PM Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> wrote: > > We mentionned during the weekly release meeting, it seemed too late > > for merging this work in the 24.03 release. > > > > Looking at v8, I have comments on this series: > > - rather than put a Depends-on: tag, take the lib: patch as part of > > your series, there is no need for this patch without the ptr_compress > > lib and it will avoid any CI issue (ovsrobot does not support > > Depends-on: patch- for example), > Agree, this is a better solution > > > - lib/ptr_compress/version.map is unneeded now, > > - lib/ptr_compress/, app/test/test_ptr_compress.c and > > doc/guides/prog_guide/ptr_compress_lib.rst need a MAINTAINERS entry, > > - prefer lowercase characters for mail addresses in commitlogs, > > - the documentation is not referenced in doc/guides/prog_guide/index.rst, > > - doxygen does not know of this new library, you must update > > doc/api/doxy-api-index.md and doc/api/doxy-api.conf.in, > > - a RN entry is missing, > Apologies for missing these. > > > > > There were also comments on the lib: patch. > Not sure which comments you are talking about. Your comments on V7 were > addressed in V8.
http://inbox.dpdk.org/dev/zemodbht6fmbu...@bricha3-mobl1.ger.corp.intel.com/T/#m665026fb0c7ed832d3e80b68b16d7549124f6880 -- David Marchand
