> Subject: RE: [PATCH] net/netvsc: fix number Tx queues > Rx queues > > > Subject: Re: [PATCH] net/netvsc: fix number Tx queues > Rx queues > > > > On Thu, 29 Feb 2024 19:29:11 +0000 > > Alan Elder <alan.el...@microsoft.com> wrote: > > > > > The previous code allowed the number of Tx queues to be set higher > > > than the number of Rx queues. If a packet was sent on a Tx queue > > > with index > > > >= number Rx queues there was a segfault. > > > > > > This commit fixes the issue by creating an Rx queue for every Tx > > > queue meaning that an event buffer is allocated to handle receiving > > > Tx completion messages. > > > > > > mbuf pool and Rx ring are not allocated for these additional Rx > > > queues and RSS configuration ensures that no packets are received on > them. > > > > > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > > > Cc: sthem...@microsoft.com > > > Cc: sta...@dpdk.org > > > > > > Signed-off-by: Alan Elder <alan.el...@microsoft.com> > > > > Don't have Azure account to test, but looks good to me. > > > > Acked-by: Stephen Hemminger <step...@networkplumber.org> > > Please hold on while we are discussing this patch internally with its > interaction > with MANA. > > Long
Thanks for the feedback Long and Stephen. We've discussed the interaction with MANA and I think we're good to go ahead with this now. I've submitted v2 of the patch with a minor fix. Cheers, Alan