On Fri, Mar 8, 2024 at 12:39 AM Stephen Hemminger
<step...@networkplumber.org> wrote:
>
> From: Isaac Boukris <ibouk...@gmail.com>
>
> If request to set promiscious mode failed at startup,
> then it is not necessary to disable it when shutting down.
>
> This should only be issue if with a buggy driver because if
> driver does not support setting promiscious it would just
> ignore request to disable it as well.
>
> Fixes: 6026bfae07d4 ("app/dumpcap: support multiple interfaces")
> Signed-off-by: Isaac Boukris <ibouk...@gmail.com>
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> ---
> v2 - add more to commit log, and simplify the logic
>
> app/dumpcap/main.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
> index 76c747511444..11e470391edb 100644
> --- a/app/dumpcap/main.c
> +++ b/app/dumpcap/main.c
> @@ -828,12 +828,9 @@ static void enable_pdump(struct rte_ring *r, struct
> rte_mempool *mp)
> if (rte_eth_promiscuous_get(intf->port) == 1) {
> /* promiscuous already enabled */
> intf->opts.promisc_mode = false;
> - } else {
> - ret = rte_eth_promiscuous_enable(intf->port);
> - if (ret != 0)
> - fprintf(stderr,
> - "port %u set promiscuous
> enable failed: %d\n",
> - intf->port, ret);
> + } else if (rte_eth_promiscuous_enable(intf->port) <
> 0) {
> + fprintf(stderr, "port %u:%s set promiscuous
> failed\n",
> + intf->port, intf->name);
> intf->opts.promisc_mode = false;
> }
> }
> --
> 2.43.0
>
V2 looks good to me.
Thanks!
