On 2024-03-02 18:07, Stephen Hemminger wrote:
On Sat, 2 Mar 2024 14:53:28 +0100
Mattias Rönnblom <mattias.ronnb...@ericsson.com> wrote:
diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h
index b5a9df5930..783dd0e1ee 100644
--- a/lib/eal/include/rte_bitops.h
+++ b/lib/eal/include/rte_bitops.h
@@ -1179,6 +1179,10 @@ __RTE_GEN_BIT_ATOMIC_OPS(64)
* The address holding the bit.
* @return
* The target bit.
+ * @note
+ * This function is deprecated. Use rte_bit_test32(),
+ * rte_bit_once_test32(), or rte_bit_atomic_test32() instead,
+ * depending on exactly what guarantees are required.
*/
static inline uint32_t
rte_bit_relaxed_get32(unsigned int nr, volatile uint32_t *addr)
The DPDK process is:
- mark these as deprecated in release notes of release N.
- mark these as deprecated using __rte_deprecated in next LTS
- drop these in LTS release after that.
Don't use notes for this.
Don't use notes to replace the above process, or don't use notes at all?
A note seems useful to me, especially considering there is a choice to
be made (not just mindlessly replacing one call with another).
Anyway, release notes updates have to wait so I'll just drop this patch
for now.
