On 2/28/2024 10:18 PM, Stephen Hemminger wrote: > On Tue, 27 Feb 2024 19:15:49 +0800 > Chaoyong He <chaoyong...@corigine.com> wrote: > >> From: Peng Zhang <peng.zh...@corigine.com> >> >> Add the elf module, which can get mip information from the >> firmware ELF file. >> >> Signed-off-by: Peng Zhang <peng.zh...@corigine.com> >> Reviewed-by: Chaoyong He <chaoyong...@corigine.com> >> Reviewed-by: Long Wu <long...@corigine.com> >> --- > > Why are you rolling your own ELF parser? > There are libraries to do this such as libelf. > Libelf is already used in the BPF part of DPDK. >
There cons and pros to depend external library, as this is in the limited scope of the driver I am less concerned about local code. Chaoyong, what is your take on the issue, did you consider using libelf library option?
