Re: [PATCH] app/dma-perf: add average latency per worker

[Varghese, Vipin]

On 2/23/2024 3:15 PM, fengchengwen wrote:
Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


Hi Vipin,

On 2023/12/20 0:40, Vipin Varghese wrote:
Modify the user display data with total average latency per worker.

Signed-off-by: Vipin Varghese <vipin.vargh...@amd.com>
---
  app/test-dma-perf/benchmark.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c
index 9b1f58c78c..8b6886af62 100644
--- a/app/test-dma-perf/benchmark.c
+++ b/app/test-dma-perf/benchmark.c
@@ -470,7 +470,8 @@ mem_copy_benchmark(struct test_configure *cfg, bool is_dma)
               bandwidth_total += bandwidth;
               avg_cycles_total += avg_cycles;
       }
-     printf("\nTotal Bandwidth: %.3lf Gbps, Total MOps: %.3lf\n", 
bandwidth_total, mops_total);
+     printf("\nAverage Cycles/op: %.2lf, Total Bandwidth: %.3lf Gbps, Total MOps: 
%.3lf\n",
+                     (float) avg_cycles_total / nb_workers, bandwidth_total, 
mops_total);

thanks for the suggestions, please find my observations below

Because this is total stats, suggest add Total prefix, e.g. "Total Average 
Cycles/op"
I did not follow this, so please let me try to explain my understanding. 
For `n` operation we count the average cycles, then
we add the cycles to form `total average cycles`; this is then divide by 
`n` operations. Making this per operation what is the
average cycles taken for the round trip time. Hence `Total Average 
Cyeles/op` does not sound right, but `Average Cycles / op` does.
I think print format keep one-digit precision is enough. Also please modify 
CSV_TOTAL_LINE_FMT
make sure the csv also have same precision of Cycles/op.

We have checked the CSV formatting a find
1. the precision for average cycle/op is 2 digits precision.
2. already the CVS format has average cycles/op integrated.

Hence no change is required.


Thanks

       snprintf(output_str[MAX_WORKER_NB], MAX_OUTPUT_STR_LEN, 
CSV_TOTAL_LINE_FMT,
                       cfg->scenario_id, nr_buf, memory * nb_workers,
                       avg_cycles_total / nb_workers, bandwidth_total, 
mops_total);