09/11/2023 11:20, Jie Hai: > Field 'flags' of struct rte_ring is defined as int type. However, > it is used as unsigned int. To ensure consistency, change the > type of flags to unsigned int. Since these two types has the > same byte size, this change is not an ABI change. > > Fixes: af75078fece3 ("first public release") > > Signed-off-by: Jie Hai <haij...@huawei.com> > Acked-by: Konstantin Ananyev <konstantin.v.anan...@yandex.ru> > Acked-by: Chengwen Feng <fengcheng...@huawei.com> > Acked-by: Morten Brørup <m...@smartsharesystems.com> > --- > lib/ring/rte_ring_core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h > index b7708730658a..14dac6495d83 100644 > --- a/lib/ring/rte_ring_core.h > +++ b/lib/ring/rte_ring_core.h > @@ -119,7 +119,7 @@ struct rte_ring_hts_headtail { > struct rte_ring { > char name[RTE_RING_NAMESIZE] __rte_cache_aligned; > /**< Name of the ring. */ > - int flags; /**< Flags supplied at creation. */ > + uint32_t flags; /**< Flags supplied at creation. */
This triggers a warning in our ABI checker: in pointed to type 'struct rte_ring' at rte_ring_core.h:119:1: type size hasn't changed 1 data member change: type of 'int flags' changed: entity changed from 'int' to compatible type 'typedef uint32_t' at stdint-uintn.h:26:1 type name changed from 'int' to 'unsigned int' type size hasn't changed I guess we were supposed to merge this in 23.11, sorry about this. How can we proceed?