15/02/2024 23:20, Tyler Retzlaff: > Provide a new macro __rte_attribute(a) that when directly used > compiles to empty for MSVC and to __attribute__(a) when using GCC/LLVM. > > Replace direct use of __attribute__ in __rte_xxx macros where there is > existing empty expansion of the macro for MSVC allowing removal of > repeated #ifdef RTE_TOOLCHAIN_MSVC per macro to expand empty.
I'm not sure it makes sense. I prefer seeing clearly what is empty with MSVC.