On Sat, 17 Feb 2024 19:02:30 +0100 Morten Brørup <m...@smartsharesystems.com> wrote:
> Not formally... it follows the official DPDK Coding Style [1]. > > [1]: https://doc.dpdk.org/guides/contributing/coding_style.html#general > > > Should be: > > > > if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0 && > > (ol_flags & RTE_MBUF_F_TX_UDP_SEG) == 0) > > goto clean_txd; > > This indentation style is mentioned as an alternative in the guide. But the > example in the guide also uses two tabs for a similar long comparison. > > Personally, I also prefer the style suggested by Stephen, so we might want to > update the Coding Style. ;-) The two tabs is an Intel thing, and I prefer the kernel, line up the conditional style. We really should have a style that can be describe by clang format. Other projects like VPP have a target that reformats the code and uses one of the clang format templates.
