> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 16 February 2024 04.36 > > EAL logtype should be reserved for EAL library. > This example is already using printf() so just print > errors to stderr. > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > Acked-by: Huisong Li <lihuis...@huawei.com> > ---
Optionally, please consider using RTE_LOG(INFO, L2FWD, ...) instead. This would require #define RTE_LOGTYPE_L2FWD RTE_LOGTYPE_USER1 in the shm.c file too, or defining it in a common header for the two C files. And while you are at it, shm.c also has a couple of printf for warnings; please consider converting those too. Either to RTE_LOG(INFO, L2FWD, ...) or to fprintf(stderr, ...). Anyway... Acked-by: Morten Brørup <m...@smartsharesystems.com>
