Hello, On Thu, Feb 15, 2024 at 8:02 PM Parthakumar Roy <parthakumar....@ibm.com> wrote: > > Hello, > Bruce Richardson suggested that I submit this patch - at IBM we needed to > adjust the pkt_mbuf_headroom for our application to work. This is my first > ever patch through a mailing list, I have only done it through Pull Requests > before, so let me know if I need to correct something.
Thanks for the contribution. I have some comments on the form. First of all, there are issues (the change is included as part of a multipart mail + html) in the format of the change itself, which distracted our CI tools. As a result, the patch was not recognised and can't be tested by the CI. We also need a SoB. Please have a look at the contributors guide (esp. chaptors 1 and 8): https://doc.dpdk.org/guides/contributing/patches.html > > Message: > Add meson configuration option to adjust RTE_PKTMBUF_HEADROOM You must describe with more detail the goal/usecase that you want to address with a change. For example here, I am curious to know how you need to adjust the headroom. Is it for increasing it? I consider the current headroom already quite huge (it is enough to encapsulate 2 whole vxlan tunnel headers, for example). -- David Marchand
