> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, October 21, 2015 11:59 AM > To: Yoni Fogel > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] lib: rte_*_create gives NULL/EEXIST on duped > name > > On Tue, Oct 20, 2015 at 01:21:37PM -0700, Yoni Fogel wrote: > > Also fixed a bug in many of them where if the rte_malloc of > > the TAILQ fails, then we return a pointer to some arbitrary > > existing struct.
Another nit - please don't forget to update comments in the .h files, about changed behaviour. Konstantin > > > > Signed-off-by: Yoni Fogel <yrobot at amazon.com> > > Thanks, looks like good fixes. However, I think for fixes like these they are > better as one-fix-per-patch, because in this case we have the title referring > to one fix, while the comment log describes a completely separate fix. > Can you perhaps do a V2 as a two-patch set? > > /Bruce > > > --- > > lib/librte_acl/rte_acl.c | 53 > > +++++++++++++++++++++------------------ > > lib/librte_hash/rte_cuckoo_hash.c | 6 +++-- > > lib/librte_hash/rte_fbk_hash.c | 5 +++- > > lib/librte_lpm/rte_lpm.c | 5 +++- > > lib/librte_lpm/rte_lpm6.c | 5 +++- > > 5 files changed, 44 insertions(+), 30 deletions(-) > >
