Hi Gregory,

> -----Original Message-----
> From: Gregory Etelson <getel...@nvidia.com>
> Sent: Thursday, October 26, 2023 09:31
> To: dev@dpdk.org
> Cc: Gregory Etelson <getel...@nvidia.com>; Maayan Kashani
> <mkash...@nvidia.com>; Ori Kam <or...@nvidia.com>; Aman Singh
> <aman.deep.si...@intel.com>; Yuying Zhang <yuying.zh...@intel.com>
> Subject: [PATCH] app/testpmd: add size parameter to raw_encap action
>
> Testpmd always provides RAW_ENCAP flow action configuration with encap
> buffer and the buffer size.
> That implementation does not allow to create non-masked raw_encap action
> in the template API actions template.
> 
> The patch adds the `size` parameter to testpmd `raw_encap` action
> configuration.
> Testpmd can create non-masked raw-encap action template and specify encap
> buffer during flow creation.
> 
> Example:
> 
> # total data size is 50
> testpmd> set raw_encap 0 \
>          eth src is 11:22:33:44:55:66 dst is aa:bb:cc:dd:01:aa / \
>          ipv4 src is 31.31.31.31 dst is 63.63.63.1 / udp src is 1 / \
>          vxlan vni is 1 / end_set
> 
> testpmd> flow actions_template 0 create ingress \
>          actions_template_id 50 \
>          template raw_encap size 50 / jump / end \
>          mask raw_encap size 50 / jump / end \
> 
> tstpmd> flow queue 0 create 0 template_table 0 \
>         pattern_template 0 actions_template 0 postpone no \
>         pattern ... end \
>         actions raw_encap index 0 / jump group 1 / end
> 
> The new `size` parameter is mutually exclusive with the existing `index`
> parameter.
> 
> Signed-off-by: Gregory Etelson <getel...@nvidia.com>

The following sequence of commands results in "Bad arguments" error, but I 
think it should be accepted. 

testpmd> port stop all
Stopping ports...
Checking link statuses...
Done
testpmd> flow configure 0 queues_number 4 queues_size 64
Configure flows on port 0: number of queues 4 with 64 elements
testpmd> port start all
Port 0: B8:CE:F6:7B:D8:E0
Checking link statuses...
Done
testpmd> set raw_encap 0 eth src is 11:22:33:44:55:66 dst is aa:bb:cc:dd:01:aa 
/ ipv4 src is 31.31.31.31 dst is 63.63.63.1 / udp src is 1 / vxlan vni is 1 / 
end_set
testpmd> flow actions_template 0 create ingress actions_template_id 100 
template raw_encap index 0 / jump / end mask raw_encap index 0 / jump / end
Bad arguments

Could you please take a look at that?

Best regards,
Dariusz Sosnowski

Reply via email to