On Tue, Feb 6, 2024 at 11:04 AM Bruce Richardson
<bruce.richard...@intel.com> wrote:
> > @@ -631,7 +631,7 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev)
> > RTE_ETH_VLAN_FILTER_MASK |
> > RTE_ETH_VLAN_EXTEND_MASK);
> > if (err) {
> > - PMD_DRV_LOG(ERR, "Failed to update vlan offload");
> > + PMD_DRV_LOG(INFO, "There is no support or the PF refused VLAN
> > offloading");
>
> Minor nit, the phrase "no support" seems ambiguous on first reading, since
> it's not completely clear that the no support refers to vlan offloading.
>
> How about:
> "VLAN offloading is not supported, or offloading was refused by the PF"
It reads better, I'll send a v2.
Thanks Bruce.
--
David Marchand
