On Wed, Jan 31, 2024 at 06:02:49PM +0000, Bruce Richardson wrote:
> On Wed, Jan 31, 2024 at 06:45:51PM +0100, David Marchand wrote:
> > The "_disable_reason" variables are subject to naming conflicts.
> >
> > This has been caught while looking at mingw builds where the graph
> > application was skipped with an <unknown_reason> (which is caused by a
> > missing reason variable set in app/graph/meson.build) and the graph
> > library was skipped with the same <unknown_reason> too, even though
> > this library meson does set a proper reason variable.
> >
> > Example in GHA:
> >
> > =================
> > Content Skipped
> > =================
> >
> > apps:
> > dumpcap: not supported on Windows
> > graph: <unknown reason>
> > pdump: not supported on Windows
> > ...
> >
> > libs:
> > acl: not supported on Windows
> > bbdev: not supported on Windows
> > ...
> > graph: <unknown reason>
> > node: not supported on Windows
> >
> > Prefix all those variables with the type of component.
> >
> > Fixes: ecf75180171b ("build: list selected applications")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: David Marchand <david.march...@redhat.com>
>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
Acked-by: Tyler Retzlaff <roret...@linux.microsoft.com>
