Hi Venkat, > -----Original Message----- > From: Sivaramakrishnan, VenkatX <venkatx.sivaramakrish...@intel.com> > Sent: Friday, January 19, 2024 11:40 AM > To: Ji, Kai <kai...@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.gua...@intel.com> > Cc: dev@dpdk.org; Sivaramakrishnan, VenkatX > <venkatx.sivaramakrish...@intel.com> > Subject: [PATCH v1] crypto/ipsec_mb: upgrade IPsec Multi-buffer to 1.4
Could you change the commit title to "bump minimum IPSec Multi-buffer version" > > SW PMDs do not support IPsec Multi-buffer version 1.3 and less. I wouldn't say this is correct. The PMDs support these versions, but this patch is bumping the minimum version to make the code more maintainable (it's simpler) and to force users to use a newer library (which includes bugfixes and performance optimizations), with more algorithms enabled (win-win situation). > A minimum IPsec Multi-buffer version of 1.4 or greater is now required. > > Signed-off-by: Sivaramakrishnan Venkat > <venkatx.sivaramakrish...@intel.com> > --- A couple of things more: - Could you update the AESNI MB (aesni_mb.rst) documentation to show this change (the version compatibility table)? - There is a macro not needed any longer in ipsec_mb_ops.c: IMB_MP_REQ_VER_STR. Thanks! Pablo
